Murtadha Hubail has submitted this change and it was merged. Change subject: [NO ISSUE][OTH] Ensure Stats Refresh is Thread Safe ......................................................................
[NO ISSUE][OTH] Ensure Stats Refresh is Thread Safe - user model changes: no - storage format changes: no - interface changes: no Details: - Make variables used in determining the need to refresh stats volatile to ensure refresh won't be called by multiple thread if not needed. Change-Id: I07d76e53d193f93e0aaf08715e3f4c82b3b1524e Reviewed-on: https://asterix-gerrit.ics.uci.edu/2969 Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: Murtadha Hubail <[email protected]> --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Anon. E. Moose #1000171: Jenkins: Verified; No violations found; Verified Murtadha Hubail: Looks good to me, approved diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java index b034f47..62f2c02 100644 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java +++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java @@ -92,9 +92,9 @@ private AlgebricksAbsolutePartitionConstraint locations; protected ActivityState prevState; protected JobId jobId; - protected long statsTimestamp; + protected volatile long statsTimestamp; protected String stats; - protected boolean isFetchingStats; + protected volatile boolean isFetchingStats; protected int numRegistered; protected int numDeRegistered; protected volatile RecoveryTask rt; -- To view, visit https://asterix-gerrit.ics.uci.edu/2969 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07d76e53d193f93e0aaf08715e3f4c82b3b1524e Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]>
