Ali Alsuliman has posted comments on this change. Change subject: [NO ISSUE][FUN][COMP] fix ifnan(), ifnanorinf(), ifinf() ......................................................................
Patch Set 1: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/2981/1/asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ifnan/ifnan.1.adm File asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ifnan/ifnan.1.adm: Line 3: [ 2, false ] > Can you change queries instead, so the expected result remains "true"? So i Done. I changed few queries now that we check the number of arguments. https://asterix-gerrit.ics.uci.edu/#/c/2981/1/asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ifnanorinf/ifnanorinf.1.adm File asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/ifnanorinf/ifnanorinf.1.adm: Line 3: [ 2, false ] > same comment. change query instead so the expected result remains "true" Done https://asterix-gerrit.ics.uci.edu/#/c/2981/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IfInfDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IfInfDescriptor.java: PS1, Line 33: definiion > typo, should be: definition Done https://asterix-gerrit.ics.uci.edu/#/c/2981/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IfNanDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IfNanDescriptor.java: PS1, Line 33: definiion > definition Done https://asterix-gerrit.ics.uci.edu/#/c/2981/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IfNanOrInfDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IfNanOrInfDescriptor.java: PS1, Line 42: definiion > definition Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2981 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7cc3d18ca0443857ae271b6e14f2c9e920f1c1f Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
