Taewoo Kim has posted comments on this change. Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins ......................................................................
Patch Set 93: (7 comments) https://asterix-gerrit.ics.uci.edu/#/c/1076/5//COMMIT_MSG Commit Message: Line 17: - Use similarity-jaccard-prefix to enable the pp+ join strategy. Please check the other commit message and please follow the format. https://asterix-gerrit.ics.uci.edu/#/c/1076/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/FuzzyUtils.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/FuzzyUtils.java: Line 55: case UNION: Why do we add UNION here? https://asterix-gerrit.ics.uci.edu/#/c/1076/27/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java: Line 353: groupByRight += ", "; counter.set(context.getVarCounter()) https://asterix-gerrit.ics.uci.edu/#/c/1076/93/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java: Line 269 > Why this was removed? the rule scans the whole plan starting from the root. Wenhai, could you reply to this question? https://asterix-gerrit.ics.uci.edu/#/c/1076/93/asterixdb/asterix-app/src/test/resources/optimizerts/only.txt File asterixdb/asterix-app/src/test/resources/optimizerts/only.txt: Line 20: #inverted-index-join-noeqjoin/ngram-jaccard-inline.sqlpp > why are these added and commented out? Is this intentional? Needs to be removed. https://asterix-gerrit.ics.uci.edu/#/c/1076/38/asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-4.1.1/word-jaccard.1.ddl.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-4.1.1/word-jaccard.1.ddl.aql: Line 21: * We expect the join to be transformed into an prefix-based fuzzy join following with an < select. > "an 'less than' select" ? Sorry. I was not accurate. an prefix -> a prefix. https://asterix-gerrit.ics.uci.edu/#/c/1076/93/asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml File asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml: Line 2453: <!--test-case FilePath="fuzzyjoin"> > are these disabled intentionally? if yes, then should these queries be incl Hm... needs to be enabled. -- To view, visit https://asterix-gerrit.ics.uci.edu/1076 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc Gerrit-PatchSet: 93 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Chen Li <[email protected]> Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Wenhai Li <[email protected]> Gerrit-HasComments: Yes
