Taewoo Kim has posted comments on this change. Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins ......................................................................
Patch Set 93: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1076/93/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java: Line 269 > Wenhai, could you reply to this question? I think the reason is that this inline rule needs to be applied to the logical plans that are generated by AQL+ framework in buildFuzzyJoinRuleCollection(). If you see the RuleCollections class, buildLoadFieldsRuleCollection() includes this rule. And right after that, buildFuzzyJoinRuleCollection() is performed. Thus, if we just execute this once, the logical plans from AQL+ framework cannot be transformed using this rule. Wenhai, plaease correct me if I'm wrong. -- To view, visit https://asterix-gerrit.ics.uci.edu/1076 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc Gerrit-PatchSet: 93 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Chen Li <[email protected]> Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Wenhai Li <[email protected]> Gerrit-HasComments: Yes
