Taewoo Kim has posted comments on this change. Change subject: [NO ISSUE][COMP][RT] Enable multiway similarity joins ......................................................................
Patch Set 93: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1076/93/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java: Line 269 > Hm, RuleCollections.buildLoadFieldsRuleCollection() runs again after the bu Reverting to the original version would not break any run-time test cases. However, since the logical plan that the fuzzy join generates a logical plan that contains "subplan" in the newly generated plan, the plan needs to be transformed once again using this rule. In fact, as the current patch set shows, no test cases fail now. And what this rule does is detecting "subplan" and transforms it. I think a repetitive application would not cause an issue if we set "context.addToDontApplySet(this, subplanOp);" properly. -- To view, visit https://asterix-gerrit.ics.uci.edu/1076 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc Gerrit-PatchSet: 93 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Chen Li <[email protected]> Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Wenhai Li <[email protected]> Gerrit-HasComments: Yes
