Murtadha Hubail has posted comments on this change. Change subject: [ASTERIXDB-2264][ING] Introduce Http Feed Adapter ......................................................................
Patch Set 2: (13 comments) https://asterix-gerrit.ics.uci.edu/#/c/2994/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReader.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReader.java: PS2, Line 50: public private PS2, Line 127: lvlCtr we don't usually do this, it's better for readability to just put it in the next line PS2, Line 133: inRecord == false !inRecord Line 169: } catch (InterruptedException e) { > CRITICAL SonarQube violation: Add: Thread.currentThread().interrupt(); PS2, Line 170: LOGGER.log(Level.INFO, "exception thrown for " + request, e); Do this to avoid string construction if the log level isn't enabled: LOGGER.info("exception thrown for {}", request, e); https://asterix-gerrit.ics.uci.edu/#/c/2994/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReaderFactory.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReaderFactory.java: PS2, Line 41: public private PS2, Line 42: public private Line 43: public static final String KEY_CONFIGURATION_QUEUE_SIZE = "queue_size"; private PS2, Line 46: Collections.unmodifiableList(Arrays.asList(ExternalDataConstants.KEY_ADAPTER_NAME_HTTP)); You could just use Collections.singletonList(ExternalDataConstants.KEY_ADAPTER_NAME_HTTP); PS2, Line 61: throw new HyracksDataException(e.getMessage()); throw HyracksDataException.create(e); https://asterix-gerrit.ics.uci.edu/#/c/2994/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedUtils.java: PS2, Line 58: public private PS2, Line 59: public private PS2, Line 159: ; : ncMap remove -- To view, visit https://asterix-gerrit.ics.uci.edu/2994 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c197a3df557ecc01f07f0907688c4ea81379e40 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-HasComments: Yes
