Till Westmann has posted comments on this change.

Change subject: Deferred result retrieval for the QueryService
......................................................................


Patch Set 3:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1373/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java:

Line 1913:             if (bActiveTxn) {
> BLOCKER SonarQube violation:
I'm not sure this is right - bActiveTxn is set to false 11 lines above.


Line 2577:             if (bActiveTxn) {
> BLOCKER SonarQube violation:
similarly here


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1373
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72d53be824d8dbf1d9f547b01f19097d0dc18add
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-HasComments: Yes

Reply via email to