abdullah alamoudi has posted comments on this change. Change subject: Updated to match code changes to asterix ......................................................................
Patch Set 16: (3 comments) Looks good to me with the exception of the issue for the ruleset. definitely needs to be highlighted very clearly at least. I am pretty sure this would lead to many build failures in the future. I am pretty sure that is not the way to go but can be fine with a plan to address. Your call at the end. https://asterix-gerrit.ics.uci.edu/#/c/1227/16/asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADRuleSetFactory.java File asterix-bad/src/main/java/org/apache/asterix/bad/lang/BADRuleSetFactory.java: Line 39: if (logicalRuleSet.size() != 14) { I assume this will break if a new new rule has been added. Maybe you want to do something else. For example, if the size changes, print a warning log and instead of using the specific index for the "InsertBrokerNotifierForChannelRule", we can basically look for the rule number 17 by name and insert the new rule after that one. Also, this is dangerous if a rule was deleted and another was created as the system will not detect it. Definitely something to consider. https://asterix-gerrit.ics.uci.edu/#/c/1227/16/pom.xml File pom.xml: Line 24: <packaging>pom</packaging> Nooooooooooooo! Line 31: Nooooooooooooo! -- To view, visit https://asterix-gerrit.ics.uci.edu/1227 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I010b81776543e127f09f046a8601bb7184f7de9a Gerrit-PatchSet: 16 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
