Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1747 Implemented full lifecycle capabilities for distributed jobs ......................................................................
Patch Set 1: (10 comments) https://asterix-gerrit.ics.uci.edu/#/c/1377/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java: Line 326: return activityClusterGraphMap; Move mutations and reads of the map into this class as methods, such that it's easier to track which code updates the map. Line 329: public Map<JobId, Set<Constraint>> getActivityClusterGraphConstraintsMap() { Move mutations and reads of the map into this class as methods, such that it's easier to track which code updates the map. https://asterix-gerrit.ics.uci.edu/#/c/1377/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobRun.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobRun.java: Line 61: private IActivityClusterGraphGenerator acgg; > MAJOR SonarQube violation: address this? Line 97: private JobRun(ClusterControllerService ccs, DeploymentId deploymentId, JobId jobId, EnumSet<JobFlag> jobFlags) { > MAJOR SonarQube violation: address this? https://asterix-gerrit.ics.uci.edu/#/c/1377/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/DestroyJobWork.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/DestroyJobWork.java: Line 47: throw new RuntimeException("Trying to destroy a job that was never distributed!"); > CRITICAL SonarQube violation: HyracksException? https://asterix-gerrit.ics.uci.edu/#/c/1377/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerIPCI.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerIPCI.java: Line 103: > MAJOR SonarQube violation: WS. https://asterix-gerrit.ics.uci.edu/#/c/1377/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/DestroyJobWork.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/DestroyJobWork.java: Line 30: * destroy a permanently distributed job "permanently distributed" -> "pre-distributed" Line 48: throw new RuntimeException("Trying to destroy a job that was never distributed!"); HyracksException? https://asterix-gerrit.ics.uci.edu/#/c/1377/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/DistributeJobWork.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/DistributeJobWork.java: Line 52: throw new RuntimeException("Trying to distribute a job that has already been distributed!"); > CRITICAL SonarQube violation: HyracksException? Line 57: throw new RuntimeException(e); > CRITICAL SonarQube violation: HyracksDataException? -- To view, visit https://asterix-gerrit.ics.uci.edu/1377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59c3422d5c1ab7756a6a4685ac527dfe50434954 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes
