Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2459][FUN] Add var() and var_pop() aggregate function ......................................................................
Patch Set 2: (24 comments) https://asterix-gerrit.ics.uci.edu/#/c/3004/2/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/serial_var_mixed/serial_var_mixed.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/serial_var_mixed/serial_var_mixed.3.query.sqlpp: Line 20: * Description : Run serial-var over an ordered list with mixed types the input to the array_var in this testcase is a multiset because there's no order by in the subquery. Let's either fix the description or add order by https://asterix-gerrit.ics.uci.edu/#/c/3004/2/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/serial_var_pop_mixed/serial_var_pop_mixed.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/serial_var_pop_mixed/serial_var_pop_mixed.3.query.sqlpp: Line 20: * Description : Run serial-var over an ordered list with mixed types input to array_var_pop is multiset (unordered). Let's either fix the description or add order by to the subquery https://asterix-gerrit.ics.uci.edu/#/c/3004/2/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/var_mixed/var_mixed.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/var_mixed/var_mixed.3.query.sqlpp: Line 20: * Description : Run array_var over an ordered list with mixed types the input to array_var is a multiset. either fix the description or add order by to the subquery https://asterix-gerrit.ics.uci.edu/#/c/3004/2/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/var_pop_mixed/var_pop_mixed.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate-sql/var_pop_mixed/var_pop_mixed.3.query.sqlpp: Line 20: * Description : Run array_var_pop over an ordered list with mixed types the input to array_var_pop is a multiset. either fix the description or add order by to the subquery https://asterix-gerrit.ics.uci.edu/#/c/3004/2/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate/serial_var_mixed/serial_var_mixed.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate/serial_var_mixed/serial_var_mixed.3.query.sqlpp: Line 20: * Description : Run serial-var over an ordered list with mixed types the input strict_var is a multiset. either fix the description or add order by to the subquery. https://asterix-gerrit.ics.uci.edu/#/c/3004/2/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate/serial_var_pop_mixed/serial_var_pop_mixed.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate/serial_var_pop_mixed/serial_var_pop_mixed.3.query.sqlpp: Line 20: * Description : Run serial-var_pop over an ordered list with mixed types the input to strict_var_pop is a multiset. either fix the description or add order by to the subquery https://asterix-gerrit.ics.uci.edu/#/c/3004/2/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate/var_mixed/var_mixed.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate/var_mixed/var_mixed.3.query.sqlpp: Line 20: * Description : Run var over an ordered list with mixed types the input to strict_var is a multiset. either fix the description or add order by to the subquery https://asterix-gerrit.ics.uci.edu/#/c/3004/2/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate/var_pop_mixed/var_pop_mixed.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/aggregate/var_pop_mixed/var_pop_mixed.3.query.sqlpp: Line 20: * Description : Run var_pop over an ordered list with mixed types the input to strict_var_pop is a multiset. either fix the description or add order by to the subquery https://asterix-gerrit.ics.uci.edu/#/c/3004/2/asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md File asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md: Line 177: * Gets the standard deviation value of the non-null and non-missing numeric items in the given collection. this should say "gets the sample standard deviation" Line 184: * a `double` value representing the average of the non-null and non-missing numbers in the given collection, representing the sample standard deviation .... Line 204: * Gets the standard deviation value of the non-null and non-missing numeric items in the given collection. should be: "gets the population standard deviation .... " Line 211: * a `double` value representing the average of the non-null and non-missing numbers in the given collection, should be "representing the population standard deviation ... " Line 231: * Gets the standard deviation value of the non-null and non-missing numeric items in the given collection. should be "gets the sample variance ...." Line 238: * a `double` value representing the average of the non-null and non-missing numbers in the given collection, should be "representing the sample variance ...." Line 258: * Gets the standard deviation value of the non-null and non-missing numeric items in the given collection. should be "gets the population variance ...." Line 265: * a `double` value representing the average of the non-null and non-missing numbers in the given collection, should be "representing the population variance ...." Line 417: * Gets the standard deviation value of the numeric items in the given collection. sample standard deviation Line 424: * a `double` value representing the average of the numbers in the given collection, representing the sample standard deviation Line 442: * Gets the standard deviation value of the numeric items in the given collection. get the population standard deviation ... Line 449: * a `double` value representing the average of the numbers in the given collection, representing the population standard deviation ... Line 467: * Gets the standard deviation value of the numeric items in the given collection. get the sample variance ... Line 474: * a `double` value representing the average of the numbers in the given collection, representing the sample variance Line 492: * Gets the standard deviation value of the numeric items in the given collection. gets the population variance Line 499: * a `double` value representing the average of the numbers in the given collection, representing the population variance ... -- To view, visit https://asterix-gerrit.ics.uci.edu/3004 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If736c94146f1d6ee4dfa46a67737b1abd29c8e2d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: James Fang <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-HasComments: Yes
