Michael Blow has posted comments on this change. Change subject: [NO ISSUE][OTH] Do Not Close Client Connection After Failure ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3006/1/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java: Line 101: ctx.writeAndFlush(response); shouldn't we still close the connection in case of not keep alive? The test failures are due to a curl to a non-existent endpoint, which seems to hang after this patch. -- To view, visit https://asterix-gerrit.ics.uci.edu/3006 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0fce2c860eec97f3d368ee42f25dbdfc9dc0ff9 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
