Michael Blow has posted comments on this change. Change subject: [NO ISSUE][LOG] Ensure NC logDir ends with separator ......................................................................
Patch Set 1: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/2982/1/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCLogConfigurationFactory.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NCLogConfigurationFactory.java: PS1, Line 56: logDir + "nc-" + nodeId + ".log" why not use new File(logDir, ...), and let him worry about whether or not logDir has a trailing separator? PS1, Line 57: logDir + "nc-" + nodeId + "-%d{MM-dd-yy}.log.gz why not use new File(logDir, ...), and let him worry about whether or not logDir has a trailing separator? PS1, Line 66: logDir + "access-" + nodeId + ".log") why not use new File(logDir, ...), and let him worry about whether or not logDir has a trailing separator? PS1, Line 67: logDir + "access-" + nodeId + "-%d{MM-dd-yy}.log.gz" why not use new File(logDir, ...), and let him worry about whether or not logDir has a trailing separator? -- To view, visit https://asterix-gerrit.ics.uci.edu/2982 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I492428fdbf84ed6f1c4afd136dce33ac84aea3c0 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet <wael....@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Ian2 Maxon <ima...@uci.edu> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
