Hussain Towaileb has posted comments on this change.

Change subject: [ASTERIXDB-2469][TEST] Tests Can Result In False Positives For 
Numericals
......................................................................


Patch Set 1:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3009/1/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java:

PS1, Line 379: isCompatibleTypesComparator
> Could we make this a static method/function?
Done


PS1, Line 380: isIntegerStringComparator
> Could we make this a static method/function?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3009
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I918b7e5c3c39271f77a7d5a01ff634c2a0221ebc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Hussain Towaileb <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-HasComments: Yes

Reply via email to