Wail Alkowaileet has posted comments on this change. Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage ......................................................................
Patch Set 12: Code-Review+2 (26 comments) https://asterix-gerrit.ics.uci.edu/#/c/2857/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java: PS9, Line 253: Compr > remove block Done Line 274: if (json != null) { > do this at the beginning: Done PS9, Line 279: : : private IJsonSerializable deserializeDefault(Class<? extends IJsonSerializable> defaultClass) : throws HyracksDataException { : //Ensure it is registered : final String resourceId = getResourceId(defaultClass); : try { : Class<? extends IJsonSerializable> clazz = getResourceClass(resourceId); : //Using static method (fromJson) : > extract method e.g. deserializeDefault Done https://asterix-gerrit.ics.uci.edu/#/c/2857/9/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SqlppExecutionWithCompresisionTest.java: PS9, Line 51: testsuite_sqlpp.xml" > If a new test case that might cause problems to compression is added to the Done https://asterix-gerrit.ics.uci.edu/#/c/2857/9/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-none/scheme-none.1.ddl.sqlpp: PS9, Line 40: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/2857/9/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/compression/scheme-snappy/scheme-snappy.1.ddl.sqlpp: PS9, Line 40: > WS Done https://asterix-gerrit.ics.uci.edu/#/c/2857/9/asterixdb/asterix-app/src/test/resources/runtimets/rebalance.xml File asterixdb/asterix-app/src/test/resources/runtimets/rebalance.xml: PS9, Line 80: Rebalance w > Rebalance Done https://asterix-gerrit.ics.uci.edu/#/c/2857/9/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ICompressionManager.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/storage/ICompressionManager.java: PS9, Line 26: validate > validates Done https://asterix-gerrit.ics.uci.edu/#/c/2857/9/asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/ConfigurationUtil.java File asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/ConfigurationUtil.java: Line 34: } > remove empty line Done https://asterix-gerrit.ics.uci.edu/#/c/2857/9/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/dataset/hints/DatasetHints.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/dataset/hints/DatasetHints.java: PS9, Line 63: return hints; > We need to get rid of this completely. Done PS9, Line 133: > This shouldn't be treated as a hint. Done https://asterix-gerrit.ics.uci.edu/#/c/2857/9/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/compression/CompressionManager.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/compression/CompressionManager.java: PS9, Line 50: registeredSchemes > remove Done https://asterix-gerrit.ics.uci.edu/#/c/2857/9/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/impls/AbstractTreeIndex.java: PS9, Line 245: private final IFIFOPageQ > remove Done https://asterix-gerrit.ics.uci.edu/#/c/2857/9/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/AbstractBufferedFileIOManager.java File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/AbstractBufferedFileIOManager.java: PS9, Line 38: unexpected > unexpected Done PS9, Line 43: protected > private Done PS9, Line 47: IFileHan > this doesn't need to be volatile anymore Done Line 48: private volatile boolean hasOpen; > volatile Done PS9, Line 168: open > opened Done PS9, Line 173: hasBeenOpen > hasBeenOpened Done PS9, Line 283: throwException(Stri > Errors in java are scary. Rename to something that doesn't have the word "e Done https://asterix-gerrit.ics.uci.edu/#/c/2857/9/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java: PS9, Line 782: hasBeenOpen > you have to make this flag volatile for this work. Done https://asterix-gerrit.ics.uci.edu/#/c/2857/9/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/CachedPage.java File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/CachedPage.java: Line 242: } > remove Done https://asterix-gerrit.ics.uci.edu/#/c/2857/9/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/compression/file/CompressedFileManager.java File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/compression/file/CompressedFileManager.java: PS9, Line 210: */ : : private void ensureState(EnumSet<State> expectedStates) { : if (!expectedStates.contains(state)) { : throw new IllegalStateException( : "Expecting the state to be " + expectedStates + ". Currently it is " + state); : } : } : : private void changeToFunctionalState() throws HyracksDataException { : if (bufferCache.getNumPagesOfFile(fileId) == 0) { : state = State.WRITABLE; : > You could replace those by a single method ensureState(EnumSet<State> expec Done https://asterix-gerrit.ics.uci.edu/#/c/2857/9/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/compression/file/CompressedFileReference.java File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/compression/file/CompressedFileReference.java: PS9, Line 42: public FileReference getLAFFileReference() { : return lafFileRef; : } : : p > Please remove this. You could use the main constructor on the test or exten Done https://asterix-gerrit.ics.uci.edu/#/c/2857/9/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/compression/file/LAFWriter.java File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/compression/file/LAFWriter.java: PS9, Line 79: > Please review the synchronization on this class. Synchronizing on Concurren Done PS9, Line 155: essedFileManag > confiscatePage Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2857 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-HasComments: Yes
