Murtadha Hubail has posted comments on this change.

Change subject: [ASTERIXDB-2472][CONF] More Restrictive Configuration Options
......................................................................


Patch Set 2:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/3017/2/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/ExternalProperties.java:

PS2, Line 35: UNSIGNED_INTEGER
> should we add a PORT type?
Currently we have cases where we are using -1 in ports to indicate that they 
shouldn't be used (e.g. ncservice_port). We need to fix it then we can add a 
valid port type.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3017
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7236089d93f90ebdb57a87a8efa0a64cf98df845
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-HasComments: Yes

Reply via email to