Murtadha Hubail has posted comments on this change.

Change subject: [ASTERIXDB-2422][STO] Introduce compressed storage
......................................................................


Patch Set 13:

(1 comment)

The current naming between the with record, the Metadata.Dataset, and the 
cluster property seems a bit inconsistent. Let's change them as follows:
cluster property:
storage.compression.block

DDL example:
with { “storage-block-compression”: { “scheme”: “snappy”} }

Metadata.`Dataset` field:
StorageBlockCompression: {
“Scheme”: “snappy”
}

Other than that, the change looks good.

https://asterix-gerrit.ics.uci.edu/#/c/2857/13/asterixdb/asterix-app/src/test/resources/cc-compression.conf
File asterixdb/asterix-app/src/test/resources/cc-compression.conf:

PS13, Line 39: 21MB
is this increase needed?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idde6f37c810c30c7f1a5ee8bcbc1e3e5f4410031
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: Wail Alkowaileet <[email protected]>
Gerrit-HasComments: Yes

Reply via email to