Wail Alkowaileet has posted comments on this change. Change subject: [ASTERIXDB-2480][ING] Fix http-feed compatibility with JSON parser ......................................................................
Patch Set 4: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3026/4/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/http_feed_json/http_feed_json.3.post.http File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/feeds/http_feed_json/http_feed_json.3.post.http: PS4, Line 20: body It would good if we can have more than one record in a request. Just to make sure things work correctly? https://asterix-gerrit.ics.uci.edu/#/c/3026/4/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReader.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/http/HttpServerRecordReader.java: PS4, Line 60: CharArrayRecord Maybe initializing it with inititalCapacity = 0? new CharArrayRecord(0) -- To view, visit https://asterix-gerrit.ics.uci.edu/3026 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719c98376583a3316dbc291696df65a97dd4b26e Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-HasComments: Yes
