Luo Chen has posted comments on this change. Change subject: [ASTERIXDB-2468] Extend CountVarToCountOneRule to support no group-by ......................................................................
Patch Set 9: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3024/8/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/CountVarToCountOneRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/CountVarToCountOneRule.java: Line 123: boolean nullable = TypeHelper.canBeUnknown((IAType) varType); > TypeHelper.canBeUnknown() should return 'true' if type is ANY. Can we make Done. I wanted to change canBeUnknown() before, but I'm not sure what's the desirable behavior... -- To view, visit https://asterix-gerrit.ics.uci.edu/3024 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0808912cf45d3a914ebf7f69ec42f73b33c071f Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-HasComments: Yes
