Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][API][MTD] Refactor query service servlet - user model changes: no - storage format changes: no - interface changes: no ......................................................................
Patch Set 1: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/3038/1//COMMIT_MSG Commit Message: Line 7: [NO ISSUE][API][MTD] Refactor query service servlet \n https://asterix-gerrit.ics.uci.edu/#/c/3038/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java: PS1, Line 426: setFromJSON A better place for this might be QueryServiceRequestParameters.ofJson(JsonNode request). But you may just rename this now to setParamFromJSON and that can be done on a later stage. PS1, Line 432: setFromRequest A better place for this might be QueryServiceRequestParameters.of(IServletRequest request). But you may just rename this now to setParamFromRequest and that can be done on a later stage. PS1, Line 661: printPre rename to printOptionalResultFields https://asterix-gerrit.ics.uci.edu/#/c/3038/1/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java: PS1, Line 1800: "`" + dvName + "`" You may introduce a SQL++ escape method in a util and use it here. -- To view, visit https://asterix-gerrit.ics.uci.edu/3038 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbc81219cbe2f337b3c4aaf4a242ef2ebeb165c5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
