Till Westmann has posted comments on this change.

Change subject: Adds minimal SpiderSilk integration by adding the 
asterix-spidersilk module, reuqired maven dependencies, sample Dockerfile for 
node's containers, simple config file for 3 node AsterixDB cluster, a 
TestUtility to make working with SpiderSilk easier and a 
......................................................................


Patch Set 2:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3053/2//COMMIT_MSG
Commit Message:

PS2, Line 7: Adds minimal SpiderSilk integration by adding the 
asterix-spidersilk module, reuqired maven
           : dependencies, sample Dockerfile for node's containers, simple 
config file for 3 node AsterixDB
           : cluster, a TestUtility to make working with SpiderSilk easier and 
a sample test case that uses
           : all of these together.
Please format the commit message as described on 
https://cwiki.apache.org/confluence/display/ASTERIXDB/Formatting .

It might even make sense to file an improvement for this in
https://issues.apache.org/jira/projects/ASTERIXDB/ (but I'm not completely sure 
about that).


https://asterix-gerrit.ics.uci.edu/#/c/3053/2/asterixdb/asterix-spidersilk/pom.xml
File asterixdb/asterix-spidersilk/pom.xml:

PS2, Line 104: usede
s/usede/used/


https://asterix-gerrit.ics.uci.edu/#/c/3053/2/asterixdb/asterix-spidersilk/src/test/java/org/apache/asterix/spidersilk/TestUtil.java
File 
asterixdb/asterix-spidersilk/src/test/java/org/apache/asterix/spidersilk/TestUtil.java:

PS2, Line 46: 0.9.5-SNAPSHOT
Should this be the same version as above?


PS2, Line 59: pom.properties
What could be alternate ways to get this information?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3053
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd64aad26bd5cd3b6040fa53e87ae0d0d0c0a562
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Armin Balalaie <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-HasComments: Yes

Reply via email to