Till Westmann has posted comments on this change. Change subject: [NO ISSUE][API] added parse-only request parameter ......................................................................
Patch Set 2: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/3061/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java: PS2, Line 31: * Please revert this. PS2, Line 52: * Please revert this. https://asterix-gerrit.ics.uci.edu/#/c/3061/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java: PS2, Line 40: * Please revert this. PS2, Line 1496: newname inline? Maybe even make the parameter of the setter an conditional expression? https://asterix-gerrit.ics.uci.edu/#/c/3061/2/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/parser/ParseValues.java File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/parser/ParseValues.java: PS2, Line 44: + "," Not sure if we keep this method, but if we do, we should avoid the last comma inside the array. https://asterix-gerrit.ics.uci.edu/#/c/3061/2/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/util/SqlppVariableUtil.java File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/util/SqlppVariableUtil.java: PS2, Line 21: * Please revert this. -- To view, visit https://asterix-gerrit.ics.uci.edu/3061 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefa0edd1d9491335965fa9e6a1a9094d8070c83c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: [email protected] Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
