Xikui Wang has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/3068
Change subject: [NO ISSUE][EXT] Fix JRecord setField for open fields
......................................................................
[NO ISSUE][EXT] Fix JRecord setField for open fields
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
setField method should be friendly to open fields.
Change-Id: I4ec185d62e78e8100215334bc656586268314797
---
M
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/keyword_detector/keyword_detector.1.ddl.sqlpp
M
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/base/JRecord.java
2 files changed, 2 insertions(+), 7 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/68/3068/1
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/keyword_detector/keyword_detector.1.ddl.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/keyword_detector/keyword_detector.1.ddl.sqlpp
index 4402130..464ecb2 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/keyword_detector/keyword_detector.1.ddl.sqlpp
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/keyword_detector/keyword_detector.1.ddl.sqlpp
@@ -35,8 +35,7 @@
};
create type DetectResultType as open{
-id:int64,
-sensitive: boolean
+id:int64
};
create dataset EmpDataset(InputRecordType) primary key id;
diff --git
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/base/JRecord.java
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/base/JRecord.java
index 7fa9d0b..10c228d 100644
---
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/base/JRecord.java
+++
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/base/JRecord.java
@@ -99,11 +99,7 @@
if (pos >= 0) {
fields[pos] = fieldValue;
} else {
- if (openFields.get(fieldName) != null) {
- openFields.put(fieldName, fieldValue);
- } else {
- throw new
RuntimeDataException(ErrorCode.LIBRARY_JAVA_JOBJECTS_UNKNOWN_FIELD, fieldName);
- }
+ openFields.put(fieldName, fieldValue);
}
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/3068
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ec185d62e78e8100215334bc656586268314797
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <[email protected]>