Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-2490][NET] Support Encrypted Replication Connections ......................................................................
Patch Set 1: Code-Review+2 (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3092/1/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SslReplicationExecutionTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/runtime/SslReplicationExecutionTest.java: Line 81: @Parameters(name = "ReplicationExecutionTest {index}: {0}") Ssl* https://asterix-gerrit.ics.uci.edu/#/c/3092/1/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/PartitionReplica.java File asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/PartitionReplica.java: PS1, Line 98: !sc.getSocketChannel().isOpen() || !sc.getSocketChannel().isConnected() i see we use this pattern often- consider adding a method on ISocketChannel isHealthy() or something meaning open && connected? -- To view, visit https://asterix-gerrit.ics.uci.edu/3092 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9657624a5d54d4966357651efb671f3d8f0cb304 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-HasComments: Yes
