Ali Alsuliman has posted comments on this change. Change subject: [NO ISSUE] Refactoring plan optimization method ......................................................................
Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3101/1/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java: PS1, Line 77: if (AlgebricksConfig.ALGEBRICKS_LOGGER.isTraceEnabled()) { : AlgebricksConfig.ALGEBRICKS_LOGGER.trace("Starting logical optimizations.\n"); : } In this case, you need to remove this. Otherwise, we would be doing it twice. PS1, Line 81: logPlanAt("Logical Plan", Level.TRACE); : runLogicalOptimizationSets(plan, logicalRewrites); : computeSchemaBottomUpForPlan(plan); : runPhysicalOptimizationSets(plan, physicalRewrites); Define two private static final Strings. s = "Starting logical optimizations.\n" Then just call runOptimizationSets for both. Remove runPhysicalOptimizations() -- To view, visit https://asterix-gerrit.ics.uci.edu/3101 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8275bca00b41969444824cffd12f542d802bf26f Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-HasComments: Yes
