Till Westmann has posted comments on this change. Change subject: [NO ISSUE][API] added parse-only request parameter ......................................................................
Patch Set 3: (4 comments) Looks good to me. Just have a suggestion for the commit message and 3 questions on things that might be removable. https://asterix-gerrit.ics.uci.edu/#/c/3085/3//COMMIT_MSG Commit Message: PS3, Line 15: Returns parsevals as result, which has statement-parameters : as one of the key. The value of statement-parameters : is all the named parameters. The result is an object with a single "statement-parameters" field. The value of the field is an array of parameter names. https://asterix-gerrit.ics.uci.edu/#/c/3085/3/asterixdb/asterix-app/src/test/resources/parseonly/queries_sqlpp/named_01.1.query.sqlpp File asterixdb/asterix-app/src/test/resources/parseonly/queries_sqlpp/named_01.1.query.sqlpp: PS3, Line 20: /* : * Description : Test named statement parameters with json encoded request : * Expected Res : Success : * Date : Jun 2018 : */ Is this file used or can we remove it? https://asterix-gerrit.ics.uci.edu/#/c/3085/3/asterixdb/asterix-app/src/test/resources/runtimets/only_parseonly.xml File asterixdb/asterix-app/src/test/resources/runtimets/only_parseonly.xml: PS3, Line 20: <test-suite Is this file used or can we remove it? https://asterix-gerrit.ics.uci.edu/#/c/3085/3/asterixdb/asterix-app/src/test/resources/runtimets/queries/parseonly/001/parseonly_01.2.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries/parseonly/001/parseonly_01.2.query.sqlpp: PS3, Line 30: // param $p_null:json=null : // param $p_bool:json=true : // param $p_int:json=42 : // param $p_dec:json=42.5 : // param $p_dbl:json=42.5e2 : // param $p_str:json="hello" : // param $p_arr:json=["99",100,{"a":null},null,true] : // param $p_obj:json={"a":[1,2,3]} Should we remove these parameter bindings? I think that they should not matter for this functionality. Is that correct? -- To view, visit https://asterix-gerrit.ics.uci.edu/3085 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd2f461c22b05a5fcaa50a6e4f9b7dcd91acc184 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: [email protected] Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
