Dmitry Lychagin has submitted this change and it was merged. Change subject: [NO ISSUE] Improve stability of window function tests ......................................................................
[NO ISSUE] Improve stability of window function tests - user model changes: no - storage format changes: no - interface changes: no Details: - Add ORDER BY to some window function tests to make their results deterministic Change-Id: Ibf0858074a75d2169c1f1974585ce1c5ddb32b50 Reviewed-on: https://asterix-gerrit.ics.uci.edu/3104 Sonar-Qube: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Contrib: Jenkins <[email protected]> Reviewed-by: Ali Alsuliman <[email protected]> --- M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/pg_win/pg_win.82.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/pg_win/pg_win.83.query.sqlpp 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Anon. E. Moose #1000171: Ali Alsuliman: Looks good to me, approved Jenkins: Verified; No violations found; ; Verified diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/pg_win/pg_win.82.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/pg_win/pg_win.82.query.sqlpp index fc86522..e3421ec 100644 --- a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/pg_win/pg_win.82.query.sqlpp +++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/pg_win/pg_win.82.query.sqlpp @@ -24,5 +24,7 @@ use test; FROM (SELECT VALUE tenk1 FROM tenk1 WHERE unique2 < 10 ORDER BY four, ten LIMIT 10) s -SELECT last_value(ten) OVER (PARTITION BY four) AS `last_value`, ten, four +SELECT + last_value(ten) OVER (PARTITION BY four ORDER BY ten ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) AS `last_value`, + ten, four ORDER BY four, ten; \ No newline at end of file diff --git a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/pg_win/pg_win.83.query.sqlpp b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/pg_win/pg_win.83.query.sqlpp index ea44416..2f854ce 100644 --- a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/pg_win/pg_win.83.query.sqlpp +++ b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/pg_win/pg_win.83.query.sqlpp @@ -24,7 +24,9 @@ use test; FROM (SELECT VALUE tenk1 FROM tenk1 WHERE unique2 < 10 ORDER BY four, ten LIMIT 10) s -SELECT nth_value(ten, four + 1) OVER (PARTITION BY four) AS `nth_value`, ten, four +SELECT + nth_value(ten, four + 1) OVER (PARTITION BY four ORDER BY ten ROWS BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING) AS `nth_value`, + ten, four ORDER BY four, ten -- To view, visit https://asterix-gerrit.ics.uci.edu/3104 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf0858074a75d2169c1f1974585ce1c5ddb32b50 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]>
