Till Westmann has posted comments on this change. Change subject: [NO ISSUE] Interval join tests written in SQL++ ......................................................................
Patch Set 6: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3111/6/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/temporal/interval_joins/interval_after/interval_after.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/temporal/interval_joins/interval_after/interval_after.3.query.sqlpp: PS6, Line 27: select element { "staff" : f.name, "student" : d.name } For the SELECT clauses, my first preference would be select f.name as staff, d.name as student for its SQL-style and my second preference would be select value { "staff" : f.name, "student" : d.name } as that's what we use in the diverse SQL++ tutorials. But obviously all 3 are equivalent and don't impact the validity of the test at all. https://asterix-gerrit.ics.uci.edu/#/c/3111/6/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml File asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml: PS6, Line 10204: WS -- To view, visit https://asterix-gerrit.ics.uci.edu/3111 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cd7bcbb1a8dffa037b0f4f63fc6d86d54505adc Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Preston Carman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
