Dmitry Lychagin has posted comments on this change. Change subject: [FUN][RT] Objects creation in array functions ......................................................................
Patch Set 3: (1 comment) Can you also double check other runtime code that uses CastTypeEvaluator and see whether those classes should also call the new deallocatePointables() method? https://asterix-gerrit.ics.uci.edu/#/c/3129/3/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayPutDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArrayPutDescriptor.java: Line 107: private final boolean[] add; minor. you could use BitSet instead of the boolean array -- To view, visit https://asterix-gerrit.ics.uci.edu/3129 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib6c8c55ed3e0a35e00c5976a46e9ed6e432a6e9f Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
