Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/3144

Change subject: [NO ISSUE] Factor out date formatting
......................................................................

[NO ISSUE] Factor out date formatting

- user model changes: no
- storage format changes: no
- interface changes: no

Change-Id: Id0b723865141bb7eecf87830537d8310bfe2a5d3
---
M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADateTime.java
1 file changed, 6 insertions(+), 12 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/44/3144/1

diff --git 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADateTime.java 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADateTime.java
index 62e5c87..df38d1c 100644
--- 
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADateTime.java
+++ 
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADateTime.java
@@ -106,24 +106,18 @@
 
     @Override
     public String toString() {
-        StringBuilder sbder = new StringBuilder();
-        sbder.append("datetime: { ");
-        try {
-            
GregorianCalendarSystem.getInstance().getExtendStringRepUntilField(chrononTime, 
0, sbder,
-                    GregorianCalendarSystem.Fields.YEAR, 
GregorianCalendarSystem.Fields.MILLISECOND, true);
-        } catch (IOException e) {
-            throw new RuntimeException(e);
-        }
-        sbder.append(" }");
-        return sbder.toString();
+        return appendDatetime(new StringBuilder().append("datetime: { "), 
chrononTime).append(" }").toString();
     }
 
     public String toSimpleString() {
-        StringBuilder sbder = new StringBuilder();
+        return appendDatetime(new StringBuilder(), chrononTime).toString();
+    }
+
+    private static StringBuilder appendDatetime(StringBuilder sbder, long 
chrononTime) {
         try {
             
GregorianCalendarSystem.getInstance().getExtendStringRepUntilField(chrononTime, 
0, sbder,
                     GregorianCalendarSystem.Fields.YEAR, 
GregorianCalendarSystem.Fields.MILLISECOND, true);
-            return sbder.toString();
+            return sbder;
         } catch (IOException e) {
             throw new IllegalStateException(e);
         }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3144
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0b723865141bb7eecf87830537d8310bfe2a5d3
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <[email protected]>

Reply via email to