Dmitry Lychagin has posted comments on this change. Change subject: [No Issue] [COMP] Hooks to disable constant folding and recordType forwarding from scalars to evaluators - user model changes: no - storage format changes: no - interface changes: ......................................................................
Patch Set 4: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/3130/4//COMMIT_MSG Commit Message: Line 7: [No Issue] [COMP] Hooks to disable constant folding and recordType forwarding from scalars to evaluators [NO ISSUE] (upper case), and add a new line after this one. Line 12: Change-Id: Id635af97e2800d8f5a2034aef751f74797314119 move "Change-Id" below "Details" https://asterix-gerrit.ics.uci.edu/#/c/3130/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ConstantFoldingRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/ConstantFoldingRule.java: Line 100: private static final ImmutableSet<FunctionIdentifier> BUILTIN_FUNC_ID_SET_THAT_SHOULD_NOT_BE_APPLIED = Why keep the original set if we're making a copy of it? Seems like a waste of memory. We need to initialize FUNC_ID_SET_THAT_SHOULD_NOT_BE_APPLIED with the initial set of functions and let extensions add more functions to it. We could just do FUNC_ID_SET_THAT_SHOULD_NOT_BE_APPLIED = Sets.newHashSet( RECORD_MERGE, ADD_FIELDS, ... ) and remove BUILTIN_FUNC_ID_SET_THAT_SHOULD_NOT_BE_APPLIED field https://asterix-gerrit.ics.uci.edu/#/c/3130/4/asterixdb/asterix-om/src/main/java/org/apache/asterix/runtime/evaluators/base/AbstractScalarFunctionDynamicDescriptor.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/runtime/evaluators/base/AbstractScalarFunctionDynamicDescriptor.java: Line 33: @Override This method is already defined in AbstractFunctionDescriptor, no need to override. Let's remove this one. -- To view, visit https://asterix-gerrit.ics.uci.edu/3130 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id635af97e2800d8f5a2034aef751f74797314119 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: [email protected] Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
