Till Westmann has posted comments on this change. Change subject: DateTime parsing records date time separator - user model changes: no - storage format changes: no - interface changes: no ......................................................................
Patch Set 3: Code-Review+1 (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3131/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/temporal/DateTimeFormatUtils.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/temporal/DateTimeFormatUtils.java: PS1, Line 282: onon, Mutable<Boo Call this 'dateTimeSeparatorOut' as this is an output parameter? Line 282: public boolean parseDateTime(AMutableInt64 outChronon, Mutable<Boolean> outTimeZoneExists, > use AMutableInt8 Would it make sense to use a Mutable<Character> here? Even the "...separatorChar" members are initialized with char constants. -- To view, visit https://asterix-gerrit.ics.uci.edu/3131 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09478c76cb85a02048b1d36f8fbaafa4efcb0e4f Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: [email protected] Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
