Till Westmann has submitted this change and it was merged. Change subject: [NO ISSUE] Factor out date formatting ......................................................................
[NO ISSUE] Factor out date formatting - user model changes: no - storage format changes: no - interface changes: no Change-Id: Id0b723865141bb7eecf87830537d8310bfe2a5d3 Reviewed-on: https://asterix-gerrit.ics.uci.edu/3144 Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Contrib: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: Murtadha Hubail <[email protected]> --- M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADateTime.java 1 file changed, 6 insertions(+), 12 deletions(-) Approvals: Jenkins: Verified; No violations found; ; Verified Murtadha Hubail: Looks good to me, approved Objections: Anon. E. Moose #1000171: Violations found diff --git a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADateTime.java b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADateTime.java index 62e5c87..df38d1c 100644 --- a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADateTime.java +++ b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/ADateTime.java @@ -106,24 +106,18 @@ @Override public String toString() { - StringBuilder sbder = new StringBuilder(); - sbder.append("datetime: { "); - try { - GregorianCalendarSystem.getInstance().getExtendStringRepUntilField(chrononTime, 0, sbder, - GregorianCalendarSystem.Fields.YEAR, GregorianCalendarSystem.Fields.MILLISECOND, true); - } catch (IOException e) { - throw new RuntimeException(e); - } - sbder.append(" }"); - return sbder.toString(); + return appendDatetime(new StringBuilder().append("datetime: { "), chrononTime).append(" }").toString(); } public String toSimpleString() { - StringBuilder sbder = new StringBuilder(); + return appendDatetime(new StringBuilder(), chrononTime).toString(); + } + + private static StringBuilder appendDatetime(StringBuilder sbder, long chrononTime) { try { GregorianCalendarSystem.getInstance().getExtendStringRepUntilField(chrononTime, 0, sbder, GregorianCalendarSystem.Fields.YEAR, GregorianCalendarSystem.Fields.MILLISECOND, true); - return sbder.toString(); + return sbder; } catch (IOException e) { throw new IllegalStateException(e); } -- To view, visit https://asterix-gerrit.ics.uci.edu/3144 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0b723865141bb7eecf87830537d8310bfe2a5d3 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]>
