Michael Blow has posted comments on this change. Change subject: [NO ISSUE] Remove un-neccessary Jackson printer ......................................................................
Patch Set 2: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/3150/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ResultExtractor.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ResultExtractor.java: PS2, Line 21: import java.io.ByteArrayOutputStream; ? PS2, Line 30: import com.fasterxml.jackson.core.JsonEncoding; : import com.fasterxml.jackson.core.JsonGenerator; : import com.fasterxml.jackson.core.util.DefaultPrettyPrinter; : import com.fasterxml.jackson.databind.ObjectWriter; not sure all of these are needed (e.g. JsonEncoding), but they are in the wrong place regardless. it should be: import static * <blank line> java.* <blank line> javax.* <blank line> org.* <blank line> com.* <blank line> all others PS2, Line 35: import org.apache.avro.data.Json; ? -- To view, visit https://asterix-gerrit.ics.uci.edu/3150 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I465d4f0d4352f2bd7eb3ec40062a998de578d8c6 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-HasComments: Yes
