Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison ......................................................................
Patch Set 2: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/3173/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalComplexBinaryComparator.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalComplexBinaryComparator.java: Line 72: // maybe we can invoke the scalar comparison? or we can even reduce this comparator to be the generic one? when can this happen? LogicalComparatorUtil creates this comparator only if both types are derived. If input data does not match type definition, then should we just raise some sort of internal error? Line 125: if (!ATypeHierarchy.isCompatible(leftRuntimeTag, rightRuntimeTag)) { is this just checking whether the two types are the same? because there're no other compatibility rules define in ATypeHierarchy for derived types. PS2, Line 206: if (result != Result.EQ) { > I just found a case where we want to have some opinion. I think NULL is the right answer based on the pair-wise comparison. Let's double check with Mike though -- To view, visit https://asterix-gerrit.ics.uci.edu/3173 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
