Ali Alsuliman has posted comments on this change. Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison ......................................................................
Patch Set 2: (7 comments) https://asterix-gerrit.ics.uci.edu/#/c/3173/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalComplexBinaryComparator.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalComplexBinaryComparator.java: PS2, Line 67: comparisonResult > It seems that we're adding another option to the Result enum (one that we c I don't see we are adding another option. This is internal. Would that another option be useful for the calling functions (EQ, LT, ....) Line 72: // maybe we can invoke the scalar comparison? or we can even reduce this comparator to be the generic one? > when can this happen? LogicalComparatorUtil creates this comparator only if I changed it to illegal state exception. PS2, Line 101: if (result == Result.LT) { : return Result.GT; : } else if (result == Result.GT) { : return Result.LT; : } : return result; > maybe Done PS2, Line 122: byte[] leftBytes, int leftStart, : int leftLen > Should we pass a Pointable here? Let's see how it would look like when I introduce the other parts (records and multisets). I would have to create/get a pointable in the pool in that case. Line 125: if (!ATypeHierarchy.isCompatible(leftRuntimeTag, rightRuntimeTag)) { > is this just checking whether the two types are the same? because there're Yes. I changed it now. PS2, Line 206: if (result != Result.EQ) { > I think NULL is the right answer based on the pair-wise comparison. Let's d Sure. https://asterix-gerrit.ics.uci.edu/#/c/3173/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/util/container/IObjectPool.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/util/container/IObjectPool.java: PS2, Line 41: markFree > Just call it "free"? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/3173 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
