Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison ......................................................................
Patch Set 7: Code-Review+2 (21 comments) There are a number of comments and open questions on the test results. But, as a) this change does not break existing functionality and b) we know that follow-up changes will be submitted soon, we can merge this change now and address the comments in the follow-up changes. https://asterix-gerrit.ics.uci.edu/#/c/3173/6/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.004.regexjson File asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.004.regexjson: PS6, Line 1: { Could this be an adm file? https://asterix-gerrit.ics.uci.edu/#/c/3173/6/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.005.regexjson File asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.005.regexjson: PS6, Line 1: { Could this be an adm file? https://asterix-gerrit.ics.uci.edu/#/c/3173/6/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.006.regexjson File asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.006.regexjson: PS6, Line 1: { Could this be an adm file? https://asterix-gerrit.ics.uci.edu/#/c/3173/6/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.007.regexjson File asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.007.regexjson: PS6, Line 1: { Could this be an adm file? https://asterix-gerrit.ics.uci.edu/#/c/3173/6/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.020.regexjson File asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.020.regexjson: PS6, Line 1: { Could this be an adm file? PS6, Line 3: false This is because there's no '-0' in the integer domain? PS6, Line 10: NaN Not sure how 'NaN' should compare. Is this result consistent with the Java (and/or SQL) developer expectation? https://asterix-gerrit.ics.uci.edu/#/c/3173/6/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.021.regexjson File asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.021.regexjson: PS6, Line 1: { Could this be an adm file? PS6, Line 8: "[1,2] < [1,2,missing]", "r": true This is interesting. It seems that the length comparison kicks in before looking at remaining values. Do other languages do this similarly? PS6, Line 13: "[null,1] = [1,1,3]", "r": false Should this be 'null'? PS6, Line 18: false null? PS6, Line 24: false null? PS6, Line 25: false missing? PS6, Line 26: false missing? PS6, Line 27: false missing? PS6, Line 28: false missing? PS6, Line 32: true null? https://asterix-gerrit.ics.uci.edu/#/c/3173/6/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.022.regexjson File asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.022.regexjson: PS6, Line 6: false null? PS6, Line 8: false null? PS6, Line 9: false null? PS6, Line 10: "t9" stopping here. -- To view, visit https://asterix-gerrit.ics.uci.edu/3173 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
