Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2516][RT] record deep comparison (ordering) ......................................................................
Patch Set 1: Code-Review+2 (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/3234/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/AbstractAGenericBinaryComparator.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/AbstractAGenericBinaryComparator.java: PS1, Line 121: // TODO(ali): extract IObjectFactory factories into a separate unit and share yes PS1, Line 430: leftFieldName it seems a bit strange that a field name needs to be "visitable" PS1, Line 491: getIndex I think that we should try to maintain the position instead of searching here. https://asterix-gerrit.ics.uci.edu/#/c/3234/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnorderedListType.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/AUnorderedListType.java: Line 34: // TODO: why is the item type "null"? why not ANY? > I think we should change it to be ANY. +1 -- To view, visit https://asterix-gerrit.ics.uci.edu/3234 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I186f853e0b16acdb3170f7b51bb8a5707d34f9d8 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
