Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2523][RT][COMP] add support for hashing record fields ......................................................................
Patch Set 1: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/3249/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/hash/AMurmurHash3BinaryHashFunctionFamily.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/hash/AMurmurHash3BinaryHashFunctionFamily.java: Line 161: int hash = 0; should we use the 'seed' argument as a starting value instead of eliminating it? Line 192: int hash = 0; same. use 'seed' as a starting value? Line 200: hash ^= hash(fieldType, fieldValue.getByteArray(), fieldValue.getStartOffset(), just to confirm. we're not using field names, only their values for hashing. right? -- To view, visit https://asterix-gerrit.ics.uci.edu/3249 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d18a17089afdc6e28ff01091d890b375868969c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <ali.al.solai...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
