Change in asterixdb[master]: WIP: remove statement as request body

[Michael Blow (Code Review)]

Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/3267

Change subject: WIP: remove statement as request body
......................................................................

WIP: remove statement as request body

Change-Id: I566a0c2deaf29e6da0d4dabf9d9de3bfd60da8d6
---
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
1 file changed, 6 insertions(+), 8 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/67/3267/1

diff --git 
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
index 4e4b760..e90304b 100644
--- 
a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
+++ 
b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
@@ -765,15 +765,13 @@
     protected HttpUriRequest constructPostMethodUrl(String statement, URI uri, 
String stmtParam,
             List<Parameter> otherParams) {
         RequestBuilder builder = RequestBuilder.post(uri);
-        if (stmtParam != null) {
-            for (Parameter param : upsertParam(otherParams, stmtParam, 
ParameterTypeEnum.STRING, statement)) {
-                builder.addParameter(param.getName(), param.getValue());
-            }
-            builder.addParameter(stmtParam, statement);
-        } else {
-            // this seems pretty bad - we should probably fix the API and not 
the client
-            builder.setEntity(new StringEntity(statement, UTF_8));
+        if (stmtParam == null) {
+            throw new IllegalStateException("statement param not defined!");
         }
+        for (Parameter param : upsertParam(otherParams, stmtParam, 
ParameterTypeEnum.STRING, statement)) {
+            builder.addParameter(param.getName(), param.getValue());
+        }
+        builder.addParameter(stmtParam, statement);
         builder.setCharset(UTF_8);
         return builder.build();
     }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3267
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I566a0c2deaf29e6da0d4dabf9d9de3bfd60da8d6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>