Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1755: add UPSERT in SQL++. ......................................................................
Patch Set 11: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1401/11/asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/upsert-return-custom-result/upsert-return-custom-result.3.query.aql File asterixdb/asterix-app/src/test/resources/runtimets/queries/dml/upsert-return-custom-result/upsert-return-custom-result.3.query.aql: Line 36: where $y.tweetid=5 > why this change? Because there is no way that the results can be totally ordered. Note that the stuff after returning is an expression, i.e., a FLWOGR expression here, which cannot perturb the order of the incoming tuple stream. Therefore only inserting one tuple would always get deterministic results. https://asterix-gerrit.ics.uci.edu/#/c/1401/11/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/insert-return-records/insert-return-records.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/dml/insert-return-records/insert-return-records.3.query.sqlpp: Line 28: insert into TweetMessageuuids as message ( > Do we not require "$" for variables, e.g. "$message?" No. It's SQL++, not AQL. -- To view, visit https://asterix-gerrit.ics.uci.edu/1401 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02b2be7ff2653573eccb48037895f5c8c4bc8c74 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
