Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2516][COMP] Avoid writing into buffer when comparing numbers ......................................................................
Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3272/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/ComparatorUtil.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/ComparatorUtil.java: Line 104: throw new UnsupportedOperationException(); compareNumWithConstant() and compareConstants() below return null in this case. Should they also be changed to throw exception? https://asterix-gerrit.ics.uci.edu/#/c/3272/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ATypeTag.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ATypeTag.java: Line 144: public final boolean isNumber() { we already have ATypeHierarchy.getTypeDomain() for this. Should we just use it instead? -- To view, visit https://asterix-gerrit.ics.uci.edu/3272 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie089d386a9ab8271f2833c05ffdfb0d484937b51 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
