Michael Blow has posted comments on this change. Change subject: ASTERIXDB-1714: Eliminate dependency on org.json ......................................................................
Patch Set 13: (3 comments) Reviewed the first handful of files, will complete with next patch. https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java: Line 33 revert? https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/pom.xml File asterixdb/asterix-app/pom.xml: Line 333: </dependency> > Sure, I can make it managed. +1 https://asterix-gerrit.ics.uci.edu/#/c/1392/13/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java: Line 316: .println(new ObjectMapper().writerWithDefaultPrettyPrinter().writeValueAsString(spec.toJSON())); I wonder if "new ObjectMapper().writerWithDefaultPrettyPrinter().writeValueAsString(...)" should be a Util function- seems like something we would need to do a lot and is pretty verbose/clunky... -- To view, visit https://asterix-gerrit.ics.uci.edu/1392 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9c5400fd134ae75d43385255af7794e968b1c7e Gerrit-PatchSet: 13 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
