Ali Alsuliman has posted comments on this change. Change subject: [NO ISSUE][RT] Fix list builder to re use object ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3287/1/asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/AbstractListBuilder.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/builders/AbstractListBuilder.java: PS1, Line 36: protected final GrowableArray outputStorage; : protected final IntArrayList offsets; : private final DataOutputStream outputStream; : private int metadataInfoSize; : private byte[] offsetArray; : private int offsetPosition; : private int headerSize; : private ATypeTag itemTypeTag; > why are we reordering here though? Just wanted to put the finals together and the privates together. Did I do something bad? -- To view, visit https://asterix-gerrit.ics.uci.edu/3287 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43bdfa514d9c78cfb7dfda009d0ea678ad846eba Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-HasComments: Yes
