Xikui Wang has posted comments on this change. Change subject: [NO ISSUE][FUN] Fix type inference and casting in UDFs ......................................................................
Patch Set 3: (3 comments) Thanks for your comments! https://asterix-gerrit.ics.uci.edu/#/c/3270/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastForExternalFunctionRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceDynamicTypeCastForExternalFunctionRule.java: PS3, Line 80: Boolean > /boolean/ Done PS3, Line 81: iter1 > not intro'd in this change, but can we rename iter1 to i or index or someth Is there a particular benefit for changing this, or it's a general stylistic rule? The reason I ask is bc I have been naming iterator variables this way for some time... It would useful to know if that's not the right way. PS3, Line 84: getArgumenTypes > /getArgumentTypes/ Done -- To view, visit https://asterix-gerrit.ics.uci.edu/3270 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40506fcca3cd8f14bbd6412359683433256c4c1f Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com> Gerrit-HasComments: Yes
