Murtadha Hubail has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/3291
Change subject: [NO ISSUE][NET] Do Not Track Incoming IPC Connections Handles
......................................................................
[NO ISSUE][NET] Do Not Track Incoming IPC Connections Handles
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Incoming IPC connections use a random port every time
they are established even if they are coming from the
same remote node. We should not track any incoming
connections handles.
- Since IPC handles are not reused after they are closed,
release their buffers to reduce their memory footprint
while they are in closed state.
Change-Id: I8e2328c3baf4d208bc9f4de7ce6c8d49ac7d4a61
---
M
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCHandle.java
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/91/3291/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCHandle.java
b/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCHandle.java
index 09c7c97..e502494 100644
---
a/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCHandle.java
+++
b/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCHandle.java
@@ -141,6 +141,8 @@
synchronized void close() {
setState(HandleState.CLOSED);
+ inBuffer = null;
+ outBuffer = null;
}
void processIncomingMessages() {
@@ -158,7 +160,6 @@
final boolean error = message.getFlag() == Message.ERROR;
if (!error && state == HandleState.CONNECT_RECEIVED) {
remoteAddress = (InetSocketAddress) message.getPayload();
- system.getConnectionManager().registerHandle(this);
setState(HandleState.CONNECTED);
system.getConnectionManager().ack(this, message);
} else if (!error && state == HandleState.CONNECT_SENT) {
--
To view, visit https://asterix-gerrit.ics.uci.edu/3291
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e2328c3baf4d208bc9f4de7ce6c8d49ac7d4a61
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: stabilization-f69489
Gerrit-Owner: Murtadha Hubail <[email protected]>
