Michael Blow has posted comments on this change. Change subject: [WIP] Code generator alternative ......................................................................
Patch Set 8: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/3043/8/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/PointableHelper.java: PS8, Line 161: IPointable argument > I originally had it as passing varargs in the previous patch set, however, I conjecture that a modern JVM will not heap allocate an array for this varargs invocation, due to escape analysis, inlining and/or loop unrolling. We should probably have some determination before we continue to rework the patch. PS8, Line 171: // MISSING check : if (data[offset] == ATypeTag.SERIALIZED_MISSING_TYPE_TAG) { : setMissing(result); : return true; : } : : // NULL check (Only flag at this stage) : if (data[offset] == ATypeTag.SERIALIZED_NULL_TYPE_TAG) { : setNull(result); : isNull.setValue(true); : } : : // This is reached only if it's not MISSING or NULL : return false; > That's what I'm currently contemplating. Although it makes more sense to re we should finalize on how how to pass multiple pointables first, I think, before we determine the right thing to do here. if we can just pass all the arg results in a single helper call (my vote), then setting the null / missing on the result can be done inside the helper and we can have a single boolean return true if it was null or missing (which is probably what you had before). -- To view, visit https://asterix-gerrit.ics.uci.edu/3043 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icca2e2128c4b0f2bfd8675655cf5296cbbaeba88 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
