Michael Blow has posted comments on this change. Change subject: [No Issue] [COMP] Multiple parameters for aggregation function - user model changes: no - storage format changes: no - interface changes: yes ......................................................................
Patch Set 1: (5 comments) not a comprehensive review, just a few comments https://asterix-gerrit.ics.uci.edu/#/c/3298/1//COMMIT_MSG Commit Message: PS1, Line 7: No Issue NO ISSUE Line 8: - user model changes: no blank line between header & body required https://asterix-gerrit.ics.uci.edu/#/c/3298/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/AbstractScalarAggregateDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/AbstractScalarAggregateDescriptor.java: Line 49: IScalarEvaluatorFactory[] aggFuncArgs = new IScalarEvaluatorFactory[numArgs]; //array size should depend of TypeInferer; how to get to TypeInferener > MAJOR SonarQube violation: +1 PS1, Line 49: extra space https://asterix-gerrit.ics.uci.edu/#/c/3298/1/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java: PS1, Line 171: revert -- To view, visit https://asterix-gerrit.ics.uci.edu/3298 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibaef2c0b2cf858d1aa7dd0f645f773fd04a865b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: [email protected] Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-HasComments: Yes
