Till Westmann has posted comments on this change.

Change subject: [NO ISSUE][FUN] Add Completed_Requests Function
......................................................................


Patch Set 3:

(2 comments)

Looks good, but the "elapsedTime" is strange - it seems to include time that 
passed before the query submission.

https://asterix-gerrit.ics.uci.edu/#/c/3301/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ClientRequestsRequest.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ClientRequestsRequest.java:

PS3, Line 43: RequestsType requestsType
just RequestType ?


PS3, Line 62: requests type
"request type"?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3301
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f47d523c683c3879ec52ce5bdaf16ce338e8e46
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mhub...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes

Reply via email to