Murtadha Hubail has posted comments on this change. Change subject: [ASTERIXDB-2516][RT] Move primitive comparators to Hyracks and make singleton ......................................................................
Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/3294/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/io/PersistedResourceRegistry.java: PS3, Line 218: REGISTERED_CLASSES.put("ByteBinaryComparatorFactory", ByteBinaryComparatorFactory.class); : REGISTERED_CLASSES.put("ShortBinaryComparatorFactory", ShortBinaryComparatorFactory.class); : REGISTERED_CLASSES.put("IntegerBinaryComparatorFactory", IntegerBinaryComparatorFactory.class); : REGISTERED_CLASSES.put("FloatBinaryComparatorFactory", FloatBinaryComparatorFactory.class); : REGISTERED_CLASSES.put("DoubleBinaryComparatorFactory", DoubleBinaryComparatorFactory.class); > this class makes me sad-- why can't we have a helper method which takes onl This was done to decouple the resource name from the actual class. It just happens that all the names right now match the class simple name but they don't have to be. However, if you rename any of those classes, the resource name shouldn't be renamed with it. -- To view, visit https://asterix-gerrit.ics.uci.edu/3294 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If15dc4e0dd0db942a4cadb15abbe56cbfe617b48 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
