Yingyi Bu has posted comments on this change. Change subject: Automatically set parameters. ......................................................................
Patch Set 5: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1417/5/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java: Line 41: private static int storageMemorycomponentGlobalBudgetDefault; > I'm wondering if it wouldn't be better to make all the values that are not Done Line 64: STORAGE_MEMORYCOMPONENT_GLOBALBUDGET_DEFAULT = maxHeapSize / 4; > E.g. if we made them members we could do these assignments in the construct Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1417 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02c233b86b10a998482b8d44123d45b53ebf14dc Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
